Improve Iceberg table properties building #25183
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
reviewed
Feb 28, 2025
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergMetadata.java
Outdated
Show resolved
Hide resolved
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergMetadata.java
Outdated
Show resolved
Hide resolved
jinyangli34
force-pushed
the
jinyang-dedup_partition_values
branch
from
efea506 to
46c61e3
Compare
| Iterable<FileScanTask> files = () -> lazyFiles.get().iterator(); | ||
| Iterable<PartitionStruct> partitionStructs = () -> lazyFiles.get().stream() | ||
| .map(PartitionStruct::new) | ||
| .distinct() |
There was a problem hiding this comment.
StructLike does not implement equals and hashCode. I think we need to use StructLikeWrapperWithFieldIdToIndex instead.
There was a problem hiding this comment.
This will use a LinkedHashSet internally that also uses PartitionSpec for de-dup and holds on to that object.
Since checking the partition values is sufficient, it would be better to explicitly create a HashSet on StructLikeWrapperWithFieldIdToIndex and write something similar to io.trino.plugin.iceberg.PartitionsTable#getStatisticsByPartition
There was a problem hiding this comment.
👍 updated with StructLikeWrapperWithFieldIdToIndex
jinyangli34
force-pushed
the
jinyang-dedup_partition_values
branch
2 times, most recently
from
b3f40bd to
b6f21f6
Compare
When building Iceberg table properties with many files under one partition, process this partition only once
jinyangli34
force-pushed
the
jinyang-dedup_partition_values
branch
from
b6f21f6 to
90bfe5a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When building Iceberg table properties with many files under one partition, process this partition only once
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: