Drain the input stream if the remaining data is small #25223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anusudarsan
reviewed
Mar 5, 2025
| @@ -243,6 +243,7 @@ private void closeStream() | |||
|
|
|||
| try (var _ = in) { | |||
| in.abort(); | |||
| in.release(); | |||
There was a problem hiding this comment.
can you add the reference document (in the commit message) where it was mentioned this is recommended?
| @@ -242,8 +244,16 @@ private void closeStream() | |||
| } | |||
|
|
|||
| try (var _ = in) { | |||
| in.abort(); | |||
| in.release(); | |||
| // According to the documentation: Abort will close the underlying connection, dropping all remaining data | |||
wendigo
force-pushed
the
serafin/release-after-abort
branch
from
8328c94 to
6ffc489
Compare
wendigo
force-pushed
the
serafin/release-after-abort
branch
from
6ffc489 to
b07b436
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: