Bulk fetch all columns from all tables in Oracle connector #25231
+15
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Praveen2112
requested review from
ssheikin,
ebyhr,
hashhar,
krvikash,
pajaks and
marcinsbd
krvikash
approved these changes
Mar 6, 2025
|
This isn't sufficient. There's a config for this. See mysqlclientmodule for comparision. enableBulkListing. This is from my memory (I'm AFK, will check again). |
Praveen2112
force-pushed
the
praveen/bulk_load_columns_oracle
branch
from
c3d43bd to
56b0897
Compare
hashhar
reviewed
Mar 6, 2025
|
Also can we make it so that people don't require code review to know that the added code is "dead" unless the config is enabled? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extending this #22241 framework for Oracle connector.
Additional context and related issues
Release notes
(x) Release notes are required, with the following suggested text: