-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add recursive lookup for better ensemble disconnectivity reporting #239
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice change! Very clean.
Approved your related tests here too: triton-inference-server/server#6149
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! I am curious, if this is an issue, then would it make sense to provide a sanity check
tool for ensembles ?
1bf1fe8
to
bc4d54e
Compare
I think we could, it is relatively easy to extract the static checking part of the ensemble config. |
It might even be valuable to provide some sort of visualization tool as part of this. Like one that shows a visual representation of the graph produced by Triton for the ensemble. This might be less trivial, but there are likely libraries that could make this easier. |
I would be interested in implementing this |
I believe the developer of Netron is quite open to contribution/collaboration, and we use it often for ONNX and some TensorRT stuff - it might be worth adding a config as an acceptable format. |
No description provided.