-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: enabled build behind proxy #7842
Open
dtrawins
wants to merge
8
commits into
triton-inference-server:main
Choose a base branch
from
dtrawins:proxy
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+14
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mc-nv
reviewed
Dec 11, 2024
mc-nv
reviewed
Feb 12, 2025
build.py
Outdated
@@ -1234,7 +1234,7 @@ def create_dockerfile_linux( | |||
|
|||
WORKDIR /opt/tritonserver | |||
COPY --chown=1000:1000 NVIDIA_Deep_Learning_Container_License.pdf . | |||
|
|||
ENV PIP_BREAK_SYSTEM_PACKAGES=1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line should be outdated.
This change should cover it
#7876
nv-kmcgill53
added a commit
that referenced
this pull request
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do?
Adds support to build behind proxy by mount docker/config.json into the container running the build.
Checklist
Agreement
<commit_type>: <Title>
pre-commit install, pre-commit run --all
)Commit Type:
Check the conventional commit type
box here and add the label to the github PR.
Related PRs:
Where should the reviewer start?
Test plan:
run build.py with .docker/config.json - confirm successful build behind proxy
run build.py without .docker/config.json - confirm build fails with apt install error
Caveats:
Background
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)