Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate model generation for backends on blackwell clusters #7966

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

pvijayakrish
Copy link
Contributor

@pvijayakrish pvijayakrish commented Jan 24, 2025

What does the PR do?

Separates the model generation for backends. The model generation will be performed inside the docker image.

Checklist

  • Changes are described in the pull request.
  • PR title reflects the change and is of format <commit_type>: <Title>
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging ref.
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

Check the conventional commit type
box here and add the label to the github PR.

  • build
  • ci
  • docs
  • feat
  • fix
  • perf
  • refactor
  • revert
  • style
  • test

@nv-kmcgill53
Copy link
Contributor

pre-commit checks are failing, so need to fix those.

Also, do the run_* scripts deprecate the gen_model_qa_repository script? If yes, I would like to make sure that these run_* scripts succeed when run on a local host machine.

Leaving this as a comment so I don't block the PR over next week.

@pvijayakrish pvijayakrish changed the base branch from r25.01 to main February 12, 2025 19:11
@mc-nv mc-nv self-requested a review February 12, 2025 19:19
@mc-nv
Copy link
Contributor

mc-nv commented Feb 12, 2025

Created follow up task in JIRA.
Please validate change against default branches and provide the pipeline after which I can approve the changes.

@pvijayakrish pvijayakrish force-pushed the pvijayakrish-blackwell-test-devel branch from 31a44cb to 7e45ee8 Compare February 12, 2025 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants