Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Removed workaround to install libboost-dev. Back to apt-get install #8037

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dmitry-tokarev-nv
Copy link

What does the PR do?

Removed workaround to install libboost-dev.
Back to apt-get install. Since on Ubuntu 24.04 libboost-dev 1.83.0 is available to install with apt-get.
Kept the version to show that we satisfy the version requirement >= 1.78 for boost::span

Checklist

  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging ref.
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

Check the conventional commit type
box here and add the label to the github PR.

  • build
  • ci
  • docs
  • feat
  • fix
  • perf
  • refactor
  • revert
  • style
  • test

Related PRs:

Where should the reviewer start?

Test plan:

I ran these locally

./build.py --enable-gpu --dry-run
# verified Dockerfile.buildbase
./build/docker_build

TODO: run a CI pipeline

  • CI Pipeline ID:

Caveats:

Background

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • closes GitHub issue: #xxx

@dmitry-tokarev-nv dmitry-tokarev-nv added the build Issues pertaining to builds label Feb 26, 2025
@nv-kmcgill53
Copy link
Contributor

I will wait on the CI to be linked. I would like to see x86, ARM, RHEL, and iGPU builds all pass with this change for approval.

@dmitrytokarev
Copy link

Thank you @mc-nv for pointing out all header files that used https://github.com/search?q=org%3Atriton-inference-server+boost%2F&type=code
I copied all of them into small test file test_boost.cpp:

#include <boost/algorithm/string.hpp>
#include <boost/asio.hpp>
#include <boost/asio/post.hpp>
#include <boost/asio/thread_pool.hpp>
#include <boost/core/span.hpp>
#include <boost/functional/hash.hpp>
#include <boost/interprocess/mapped_region.hpp>
#include <boost/interprocess/shared_memory_object.hpp>
#include <boost/interprocess/managed_external_buffer.hpp>
#include <boost/interprocess/sync/interprocess_condition.hpp>
#include <boost/interprocess/sync/interprocess_mutex.hpp>
#include <boost/interprocess/sync/scoped_lock.hpp>
#include <boost/program_options.hpp>
#include <boost/thread/thread_time.hpp>
#include <boost/stacktrace.hpp>
#include <boost/interprocess/allocators/allocator.hpp>
#include <boost/interprocess/detail/atomic.hpp>
#include <boost/uuid/uuid.hpp>
#include <boost/uuid/uuid_generators.hpp>
#include <boost/uuid/uuid_io.hpp>
#include <boost/interprocess/mapped_region.hpp>
#include <boost/interprocess/shared_memory_object.hpp>
#include <boost/interprocess/managed_external_buffer.hpp>
#include <boost/interprocess/sync/interprocess_condition.hpp>
int main() { return 0; }
g++ test_boost.cpp -o test_boost
echo $?
0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues pertaining to builds
Development

Successfully merging this pull request may close these issues.

3 participants