Build: Build using the PA binaries and whl if available. #8043
+20
−2,138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mc-nv
reviewed
Mar 7, 2025
Dockerfile.sdk
Outdated
| && cd /workspace/perf_analyzer/genai-perf \ | ||
| && python3 -m build --wheel --outdir /workspace/install/python | ||
| /workspace/perf_analyzer && \ | ||
| make -j16 perf-analyzer python-clients && \ |
There was a problem hiding this comment.
Why we are building this python-clients target twice, can we avoid it?
mc-nv
reviewed
Mar 7, 2025
Dockerfile.sdk
Outdated
Comment on lines
251
to
258
| RUN if [ "$PERF_ANALYZER_BUILD" = "ON" ]; then \ | ||
| pip3 install install/python/genai_perf-*.whl; \ | ||
| else \ | ||
| mkdir -p /workspace/install/python && \ | ||
| cp perf_analyzer/genai_perf-*.whl /workspace/install/python/ && \ | ||
| pip3 install /workspace/install/python/genai_perf-*.whl; \ | ||
| fi | ||
|
|
There was a problem hiding this comment.
This condition confusing me a bit.
Looks like in the same scenario two wheel packages can be available.
Dockerfile.sdk
Outdated
Comment on lines
251
to
258
| RUN if [ "$PERF_ANALYZER_BUILD" = "ON" ]; then \ | ||
| pip3 install install/python/genai_perf-*.whl; \ | ||
| else \ | ||
| mkdir -p /workspace/install/python && \ | ||
| cp perf_analyzer/genai_perf-*.whl /workspace/install/python/ && \ | ||
| pip3 install /workspace/install/python/genai_perf-*.whl; \ | ||
| fi | ||
|
|
There was a problem hiding this comment.
This condition confusing me a bit.
Looks like in the same scenario two wheel packages can be available.
Comment on lines
+252
to
+254
|
|
||
| RUN pip3 install install/python/genai_perf-*.whl; | ||
|
|
There was a problem hiding this comment.
This should be removed--it's already run directly above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do?
Build using the PA binaries and whl if available. The PR additionally removes the PA tests that are not maintained from the server repo.
Checklist
<commit_type>: <Title>Commit Type:
Check the conventional commit type
box here and add the label to the github PR.
build
ci
docs
feat
fix
perf
refactor
revert
style
test
CI Pipeline ID:
24671186
Background
TPRD-718