Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symbols in LLVM/MLIR exported by libtriton.so may alias to the symbol in the other component across two libLLVM in versioning #1236

Closed
chengjunlu opened this issue Feb 23, 2023 · 1 comment · Fixed by #3879

Comments

@chengjunlu
Copy link
Contributor

The symbols of LLVM/MLIR are exported by libtriton.so. These symbols may alias to the other components which uses different LLVM/MLIR infrastructure.

And cause issue like:
llvm/llvm-project#47565

A suggested solution is to strip all the LLVM/MLIR symbol from libtriton.so to isolate the LLVM infrastructure.
https://stackoverflow.com/questions/2222162/how-to-apply-fvisibility-option-to-symbols-in-static-libraries

ptillet pushed a commit that referenced this issue Feb 23, 2023
…ary (#1240)

This is to solve #1236

This commit hides the symbols of the shared libraries for
`libtriton.so`, so that when other object link against `libtriton.so`,
it won't have confilct.
@Stonepia
Copy link
Contributor

Solved in #1240.

It hides the symbols of the shared libraries for libtriton.so, so that when other object link against libtriton.so, there won't have conflict.

This PR didn't handle the case in MacOS, but there is a possible way to use exported_symbols_lists to export a whitelist symbols as mxnet/CMakeLists.txt. I put here in case anyone needs it.

pingzhuu pushed a commit to siliconflow/triton that referenced this issue Apr 2, 2024
…ary (triton-lang#1240)

This is to solve triton-lang#1236

This commit hides the symbols of the shared libraries for
`libtriton.so`, so that when other object link against `libtriton.so`,
it won't have confilct.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants