Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made the timezone aware issue compatible with django 1.3
Basically, I try to import django.utils.timezone and when it fails, it falls back to datetime.datetime
I had to import timedelta directly when needed, i.e., from datetime import timedelta in order to use datetime as before.
I also made the use of dateutil optional. It if's not present, it will fall back to strptime. What I don't really like about this, is that the timezone is hardcoded (+0000). dateutil will detect the correct timezone.
I would like to add some tests to make sure that all the importerrors fall back to the original state, but I could not find a way to impose the ImportError (like using mock library). Any ideas on how to do this?