web/composer: send inline URL previews #563
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumnerevans
commented
Dec 22, 2024
sumnerevans
commented
Dec 23, 2024
sumnerevans
force-pushed
the
send-msc4095-url-previews
branch
3 times, most recently
from
75d7cab to
6612b54
Compare
sumnerevans
force-pushed
the
send-msc4095-url-previews
branch
4 times, most recently
from
b4656bf to
0ffebd8
Compare
|
Seems to work fine, except a new preview isn't sent when editing a message it seems. |
sumnerevans
force-pushed
the
send-msc4095-url-previews
branch
2 times, most recently
from
26019d3 to
5d5c524
Compare
|
As is, this has an issue where if you have a URL in the composer, and then continue typing, you have a 500ms delay until you can send, even if the preview for that URL has already been gotten. I'm not really sure how to get around this. |
sumnerevans
force-pushed
the
send-msc4095-url-previews
branch
from
9761421 to
0b3d514
Compare
sumnerevans
force-pushed
the
send-msc4095-url-previews
branch
from
0b3d514 to
be739d3
Compare
sumnerevans
force-pushed
the
send-msc4095-url-previews
branch
2 times, most recently
from
8e8e99e to
a9f0d6d
Compare
Signed-off-by: Sumner Evans <[email protected]>
sumnerevans
force-pushed
the
send-msc4095-url-previews
branch
from
9a4b4ab to
527fb1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things to do:
Closes #479
Signed-off-by: Sumner Evans [email protected]