Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing "delete" function for a separate object #471

Closed
wants to merge 18 commits into from

Conversation

SamuilsRulovs
Copy link
Collaborator

Fixes #436

@SamuilsRulovs SamuilsRulovs self-assigned this Sep 6, 2021
@SamuilsRulovs SamuilsRulovs added enhancement New feature or request quality_of_life Nice to have improvement labels Sep 6, 2021
Comment on lines 925 to 927
tr("The Button works!"), QMessageBox::Ok);
//OpenInfraPlatform::Core::DataManagement::Data::removeModel(model);

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm quite sure removeModel() will be necessary.
In case it doesn't work you can also try removeallModels(), see if it works and then try to progress from there.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

auto& data = OpenInfraPlatform::Core::DataManagement::DocumentManager::getInstance().getData();
data.removeAllModels();

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fileNames -> Datei löschen?

@SamuilsRulovs
Copy link
Collaborator Author

I went through this Pull Request and concluded that it is impossible to implement the "delete" feature into the solution for now.
There is an issue with calling a function altogether (I was trying to implement suggestions from the PR discussion but until the issue with calling a function won't be solved, this feature cannot be implemented.) Therefore I am commenting out my code. (I am not sure if this code should be saved. Maybe it will make more sense to start with implementation from scratch)

@jschlenger
Copy link
Collaborator

Thank you for having another look at it.
So then I will close this pull request without merging it.

@jschlenger jschlenger closed this May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request quality_of_life Nice to have improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REQUEST] Implement function “delete” a separate object in OIP Viewer
2 participants