[WIP] Implementing IfcClothoid #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed some mistakes
…Length" for segmentation
…tion for points in convertIfcCurveSegment
…id which includes IfcParameterValue and IfcNonNegativeLengthMeasure as parameter
…ryConverter for spiral interpretation. Here the integrals for the spirals will be calculated. Source code is taken from taken Peter Bonsma
…ere the integrals for the spirals will be calculated. Source code is taken from taken Peter Bonsma
…ws incorrect rotation)
…polynomials has been redesigned. Note: functions do not display the correct angle and do not read points correctly at this time
…takes in code-interpretation were fixed. Function getPointOnCurve was updated for clothoid, namely overload was optimized. NOTE: The Angle is still displayed incorrectly. There may be a misinterpretation of the code from SpiralUtils
Elvira2227
added
enhancement
jschlenger
reviewed
Nov 11, 2021
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #304
NOTE: This pull request was made instead of #444, since it contained an error and was deleted, recovery is not possible. All previous changes are contained in the new one.