Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pull request adds new implementation for
IfcCosine
.The sturcture of the functions
getpointOnCurve
andgetDirectionOnCurve
are similar with representation of IfcSpline.Note:
There are a mistake in allready merged functions of
IfcSine
, for instance in the declaration of the template functionsgetPointOnCurve
andgetDirectionOfCurve
. Previously, the code did not reached this functions and it represents geometry only with cartesianPointList #565 . Now this mistake has been fixed.Another point corresponds to issue #560. The calculation takes quite a long time.
In the example file

cosine-curve_100.0_300_1000_1_Meter
were are not 100 point as usual, but 101. Therefore, our implementation does not reach the last point. I think, it is a bug in example file.Here is a screenshot of this example. And we see that the maximum point, which should be the last point, is just the penultimate point.
ToDo:
ReleaseNotes
SupportedIFCrepresentations