Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest versioning policy #92

Merged
merged 9 commits into from
Jan 21, 2015

Conversation

sharwell
Copy link
Member

Update to the latest versioning policies, and document them in the readme.

Fixes #89

@sharwell
Copy link
Member Author

@xanathar Can you review the new Assembly Strong Name Policy in Readme.md and let me know if it makes sense? I'm also interested in any other feedback you may have regarding the changes here.

@xanathar
Copy link

Sure! I'll do it, but sadly I can't of today, likely tomorrow.
Il 16/dic/2014 13:49 "Sam Harwell" [email protected] ha scritto:

@xanathar https://github.com/xanathar Can you review the new Assembly
Strong Name Policy in Readme.md
https://github.com/sharwell/antlr4cs/blob/latest-versioning/Readme.md#assembly-strong-name-policy
and let me know if it makes sense? I'm also interested in any other
feedback you may have regarding the changes here.


Reply to this email directly or view it on GitHub
#92 (comment)
.

@xanathar
Copy link

It seems to me pretty much fantastic :)
The only doubt is on what happens if only net35-client and portable-net40 are provided.. I mean what binary would a net40-client select ? I guess this could be a point to check for task #91.

Still, even if all of net35-client, net40-client and portable-net40 should be needed, it's a vast improvement over the situation before! (Thanks! 👍 )

@sharwell
Copy link
Member Author

A net40-client build would reference the net40-client ANTLR 4 binary, which is a drop-in replacement for either the net35-client or portable-net40 builds. The application will work regardless of which of the two builds of the intermediate library is selected by NuGet.

@xanathar
Copy link

Yes I understand that.. My question is what arrow of the two possible
choices is the one chosen by the system. Still, a nitpick, I think the
scheme is clear and great.
Il 18/dic/2014 00:19 "Sam Harwell" [email protected] ha scritto:

A net40-client build would reference the net40-client ANTLR 4 binary,
which is a drop-in replacement for either the net35-client or
portable-net40 builds. The application will work regardless of which of
the two builds of the intermediate library is selected by NuGet.


Reply to this email directly or view it on GitHub
#92 (comment)
.

@sharwell
Copy link
Member Author

NuGet will pick the portable-net40 build of the intermediate library along with the net40-client build of the ANTLR 4 Runtime.

sharwell added a commit that referenced this pull request Jan 21, 2015
@sharwell sharwell merged commit 6093ef6 into tunnelvisionlabs:master Jan 21, 2015
@sharwell sharwell deleted the latest-versioning branch January 21, 2015 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update versioning policy
2 participants