Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Namespace passing in http header #1179

Merged
merged 91 commits into from
Apr 22, 2024
Merged

Namespace passing in http header #1179

merged 91 commits into from
Apr 22, 2024

Conversation

shopifyski
Copy link
Contributor

@shopifyski shopifyski commented Mar 8, 2024 •
edited
Loading

Adding alternative to namespace inference from hostname prefix.
Utilizing NAMESPACE_METADATA_KEY to transfer namespace.
Tested with remote_sync example:

Julian and others added 30 commits February 29, 2024 15:48
wip - passing userauthcontext instead of http headers
49f044f
merged main
5fece60
@shopifyski
revert comment out
946c9ea
@shopifyski
fixed temp change
ecf2389
@shopifyski
Merge branch 'main' into jw/changing-how-jwt-is-passed-around
9521d72
@shopifyski
fixed failing tests
83e91ff
@shopifyski
next iteration of unit test fixing
b8bb476
@shopifyski
fixed remaining unit tests
e322b1a
@shopifyski
reverted debug
6b517ea
@shopifyski
removed accidentally added file
e3bd67c
@shopifyski
Merge branch 'main' into jw/changing-how-jwt-is-passed-around
8f6b127
@shopifyski
moved str to userauthcontext conversion to from trait
f038f39
@shopifyski
remove vague comment
9bc376b
@shopifyski
cargo fmt
37c130f
@shopifyski
cleaned up mod reimportss
b350ce5
@shopifyski
refactored cryptic matching in replica_proxy
d3ccabc
@shopifyski
marked potentially duplicate code with // todo dupe #auth
9b353cd
@shopifyski
refactored context to custome errors
e30d5a3
@shopifyski
added a factory to produce empty UserAuthContext
cadf427
@shopifyski
added constructors for UserAuthContext
5077466
@shopifyski
switched from try_into to using constructors
071dcf3
@shopifyski
cargo fmt
9f94e4e
@shopifyski
added tests for failing cases in parsers
284b36f
@shopifyski
adding mamespace as param wip
d0ec05a
@shopifyski
cargo fmt
f716a28
@shopifyski
added test for non-asci error
843c9f7
@shopifyski
Merge branch 'main' into jw/changing-how-jwt-is-passed-around
5c79f33
@shopifyski
Merge branch 'jw/changing-how-jwt-is-passed-around' into jw/namespace…
1340d87 
…-passing-and-auth
@shopifyski
incremental changes to make namespace as param work
047823b
@shopifyski
fixed failing test
d32bd5f
MarinPostma and others added 21 commits April 16, 2024 16:55
@MarinPostma @shopifyski
don't regen log on sqld version mismatch (tursodatabase#1296)
63797b9
@MarinPostma @shopifyski
add debug info to release build (tursodatabase#1297)
03f917b
@penberg @shopifyski
Add 'aarch64-unknown-linux-gnu' to dist targets (tursodatabase#1295)
9abf99f
@MarinPostma @shopifyski
bump sqld v0.24.6 (tursodatabase#1298)
ab63c7e
@shopifyski
Bump arm builder machine (tursodatabase#1301)
1236b5f 
Builds of arm images are hanging/crashing
@shopifyski
Revert "add debug info to release build (tursodatabase#1297)" (tursod…
cebc624 
…atabase#1300)

This reverts commit 342e4c3.
@LucioFranco @shopifyski
bottomless: upgrade s3 sdk to 1.0 (tursodatabase#1302)
ca04137 
* bottomless: upgrade s3 sdk to 1.0

* fix behavior version
@LucioFranco @shopifyski
libsql: fix embedded replica example (tursodatabase#1282)
2a1c778
@LucioFranco @shopifyski
server: add query stats to hrana responses (tursodatabase#1267)
4a363be 
* server: add query stats to hrana responses

* update spec with stats

* remove unused import

* fix snapshot

* more snapshots

* add stats to legacy api

* address comments
@LucioFranco @shopifyski
update tonic to 0.11 (tursodatabase#1308)
6b068f5
@avinassh @shopifyski
Add workflow_dispatch event trigger for PR images (tursodatabase#1306)
c1bbe15
@haaawk @shopifyski
Fix sync (tursodatabase#1316)
d0da362 
Old implementation could never finish if the write is faster than
time needed to do two round-trips to primary.

For example it's enough to have a write every 200ms to make sync
never finish if it's done in embedded replica in Sydney
if the primary and the writer are in the US.

Signed-off-by: Piotr Jastrzebski <[email protected]>
@LucioFranco @shopifyski
server: add query_duration_ms stats to query res (tursodatabase#1309)
29434c7 
* server: add `query_duration_ms` stats to query res

* hrana: default new stats fields
@LucioFranco @shopifyski
libsql: fix unwraps in local replicas (tursodatabase#1318)
18938ef
@LucioFranco @shopifyski
server: release v0.24.7 (tursodatabase#1320)
f7f2059
@shopifyski
Merge branch 'main' into jw/namespace-passing-and-auth
eaa5124
@shopifyski
Merge branch 'main' into jw/namespace-passing-and-auth
4d6a904
@shopifyski
cargo lock update
a86b89d
@shopifyski
Revert "cargo lock update"
2cacd4a 
This reverts commit a86b89d.
@shopifyski
Merge branch 'main' into jw/namespace-passing-and-auth
792a68b
@shopifyski
Merge branch 'main' into jw/namespace-passing-and-auth
66dab9d
@LucioFranco LucioFranco added this pull request to the merge queue Apr 22, 2024
Merged via the queue into tursodatabase:main with commit ca8834c Apr 22, 2024
17 checks passed
@jeremywrowe jeremywrowe deleted the jw/namespace-passing-and-auth branch April 23, 2024 13:39
@MarinPostma
Copy link
Contributor

This is a breaking change for the platform. The x-namespace-bin should be base64 encoded. We just hit this issue deploying a new canary image.

FYI, I'll patch that to base64 decode the header value.

@MarinPostma MarinPostma mentioned this pull request May 22, 2024
Merged
@MarinPostma
Copy link
Contributor

MarinPostma commented May 22, 2024 •
edited
Loading

scrap that, the platform was in the wrong

update: the header should be base64 encoded

@jameswritescode jameswritescode mentioned this pull request Dec 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haaawk haaawk haaawk left review comments

@LucioFranco LucioFranco LucioFranco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@shopifyski @MarinPostma @haaawk @LucioFranco @penberg @avinassh