Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test --doc to xtask test and the CI #897

Closed
wants to merge 8 commits into from
Closed

Add test --doc to xtask test and the CI #897

wants to merge 8 commits into from

Conversation

snacks02
Copy link
Contributor

@snacks02 snacks02 commented Jan 13, 2024

Check rust-lang/cargo#6669 for context as it seems to be the issue here.

Nextest doesn't have the --doc flag, so the only option seems to be to use cargo test --doc.

Before:

---- libsql/src/lib.rs - (line 29) stdout ----
error[E0432]: unresolved import `libsql::Frames`
 --> libsql/src/lib.rs:32:24
  |
6 | use libsql::{Database, Frames};
  |                        ^^^^^^ no `Frames` in the root
  |
  = help: consider importing one of these items instead:
          libsql::replication::Frames
          libsql_replication::rpc::replication::Frames
          pprof::Frames

error: aborting due to previous error

@snacks02 snacks02 changed the title Add cargo test --doc to the CI and fix a documentation test Add test --doc to xtask test, add it to the CI and fix a doctest Jan 15, 2024
@snacks02 snacks02 changed the title Add test --doc to xtask test, add it to the CI and fix a doctest Add test --doc to xtask test and the CI Jan 18, 2024
@snacks02 snacks02 requested a review from MarinPostma January 18, 2024 04:36
@snacks02
Copy link
Contributor Author

I see that this has been fixed in main as well, so I've updated this PR to only include the changes to CI and xtask.

@MarinPostma
Copy link
Contributor

It seems your new CI step has uncovered a failing example ;)

@snacks02
Copy link
Contributor Author

I wanted to update the PR, but was unable to because of https://github.com/tursodatabase/libsql/actions/runs/7621698836/job/20758481022.

@snacks02 snacks02 closed this Jan 29, 2024
@snacks02 snacks02 deleted the fix-documentation-test branch January 29, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants