feat: better restart handling after updating settings

tv2 · Feb 15, 2022 · 0db1dab · 0db1dab
1 parent 59b1857
commit 0db1dab
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/client/components/Settings.tsx b/client/components/Settings.tsx
@@ -10,7 +10,7 @@ import { ISettings } from '../../server/reducers/settingsReducer'
 import { Store } from 'redux'
 import { ChangeEvent } from 'react'
 import { SOCKET_SAVE_SETTINGS } from '../../server/constants/SOCKET_IO_DISPATCHERS'
-import { storeShowSettings } from '../../server/reducers/settingsActions'
+import { storeSetServerOnline, storeShowSettings } from '../../server/reducers/settingsActions'
 
 //Set style for Select dropdown component:
 const selectorColorStyles = {
@@ -169,7 +169,13 @@ class Settings extends React.PureComponent<IAppProps & Store, IState> {
         let settingsCopy = Object.assign({}, this.state.settings)
         settingsCopy.showSettings = false
         window.socketIoClient.emit(SOCKET_SAVE_SETTINGS, settingsCopy)
-        location.reload()
+        this.props.dispatch(storeShowSettings())
+        window.alert(
+            'restarting Sisyfos'
+        )
+        setTimeout(()=> {
+            location.reload()
+        }, 2000)
     }
 
     handleCancel = () => {
@@ -553,7 +559,7 @@ class Settings extends React.PureComponent<IAppProps & Store, IState> {
                         this.handleSave()
                     }}
                 >
-                    SAVE SETTINGS
+                    SAVE & RESTART
                 </button>
             </div>
         )

diff --git a/server/MainThreadHandler.ts b/server/MainThreadHandler.ts
@@ -213,6 +213,10 @@ export class MainThreadHandlers {
                 logger.data(payload).info('Save settings:')
                 saveSettings(payload)
                 this.updateFullClientStore()
+                /** Delay restart to ensure the async saveSettings is done before restarting*/
+                setTimeout(() => {
+                    process.exit(0)
+                }, 1000)
             })
             .on(IO.SOCKET_RESTART_SERVER, () => {
                 process.exit(0)