Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cspell config #35647

Merged
merged 6 commits into from
Jan 11, 2022
Merged

Update cspell config #35647

merged 6 commits into from
Jan 11, 2022

Conversation

XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented Jan 4, 2022

@coliff does this still work for you? I don't use cspell through a code editor.

@coliff
Copy link
Contributor

coliff commented Jan 4, 2022

heya - happy new year :-) - yes, I've just tested the .cspell.json config in this PR and it works well with VS Code with https://marketplace.visualstudio.com/items?itemName=streetsidesoftware.code-spell-checker installed. 👍

"zindex",
"بالعالم",
"مرحبًا"
],
"language": "en,en-US",
"language": "en, en-US",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder, if we just go with en-US, will that mean that only US English will be enforced? We already follow US English, so this might be a good change.

@XhmikosR XhmikosR requested a review from patrickhlauke January 4, 2022 08:10
Copy link
Member

@patrickhlauke patrickhlauke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't know enough about the technical side here, but the removal of extra words and the tweaks to docs look fine to me

@XhmikosR
Copy link
Member Author

XhmikosR commented Jan 5, 2022

It seems there's a gitignore config option we could use too, not sure if it's enabled by default and I can't figure it out from their docs.

@julien-deramond
Copy link
Member

It seems there's a gitignore config option we could use too, not sure if it's enabled by default and I can't figure it out from their docs.

Found this in the v5.12.0:

/**
 * Tells the spell checker to load `.gitignore` files and skip files that match the globs in the `.gitignore` files found.
 * @default false
 */
useGitignore?: boolean;

It was specified in their cspell.schema.json:

"useGitignore": {
    "default": false,
    "description": "Tells the spell checker to load `.gitignore` files and skip files that match the globs in the `.gitignore` files found.",
    "type": "boolean"
},

In the current source code it is still false by default.
The value could be switched in a next version. It was supposed to be done in v5.13.0 apparently. Don't know if it has been abandoned or forgotten.

@XhmikosR XhmikosR marked this pull request as ready for review January 11, 2022 09:15
@XhmikosR XhmikosR merged commit d581737 into main Jan 11, 2022
@XhmikosR XhmikosR deleted the main-xmr-cspell branch January 11, 2022 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants