Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lavalink broken in 0.16 rc #2319

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Conversation

LinuxDevon
Copy link
Contributor

Capitalization in a header is illegal and causes the bot to panic. I posted in discord and figured it out shortly after. https://docs.rs/http/latest/http/header/struct.HeaderName.html#method.from_static

Panics
This function panics when the static string is a invalid header.

Until Allow panicking in constants makes its way into stable, the panic message at > compile-time is going to look cryptic, but should at least point at your header value:

Steps to reproduce:

  1. checkout latest branch
  2. startup a 3.X.Y lavalink server locally
  3. build example lavalink-basic-bot

It would panic immediately on connect. See attached log of the panic. backtrace.log

@github-actions github-actions bot added the c-lavalink Affects the lavalink crate label Mar 4, 2024
@vilgotf vilgotf merged commit 02514ec into twilight-rs:main Mar 5, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-lavalink Affects the lavalink crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants