Add a flag to customize hostnames #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases it may be useful/necessary to customize the hostnames generated for the service forwardings, e.g. to emulate the configuration of an internal DNS zone that tracks k8s configurations.
|
Interesting addition. Thanks! |
|
I'll try to release a version this week. Unfortunately, I don't have tests written yet so I have a few changes to test manually when I get some time. |
|
Awesome, thank you! |
|
Hey, just checking in -- it's been some time and we're still on the previous release. Is there anything I can do to help get this shipped? |
|
Sorry I have been heads down on another project. I'll try to put out a release tonight. Thanks |
|
@memory released v1.8.3 just now. Thank you doe the contribution. |
|
on behalf of many of my team members: thank you! |
D3-LucaPiombino
pushed a commit
to CodeCoil/kubefwd
that referenced
this pull request
Jun 13, 2024
Add a flag to customize hostnames
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases it may be useful/necessary to customize the hostnames
generated for the service forwardings, e.g. to emulate the configuration
of an internal DNS zone that tracks k8s configurations.