Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add std::error::Error impls for error types #69

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add std::error::Error impls for error types #69

wants to merge 1 commit into from

Conversation

ronnodas
Copy link

@ronnodas ronnodas commented Feb 5, 2025

The trait is meant for error types. This also makes it more convenient for users wrapping biblatex's error types into their own errors and using the thiserror crate to derive error traits.

jonaspleyer
jonaspleyer approved these changes Feb 5, 2025
View reviewed changes
Copy link

@jonaspleyer jonaspleyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have just opened another PR which basically does the same. You got there first. LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonaspleyer jonaspleyer jonaspleyer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ronnodas @jonaspleyer