Skip to content

Commit

Permalink
https://forums.lanik.us/viewtopic.php?f=62&t=39280&p=129024#p129024
Browse files Browse the repository at this point in the history
  • Loading branch information
@mapx-
mapx- authored Dec 6, 2017
1 parent 2688692 commit 4633bf8
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions filters/filters.txt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2638,3 +2638,10 @@ sheshaft.com##script:inject(popads-dummy.js)
! https://github.com/uBlockOrigin/uAssets/issues/893
@@||playview.io/*/showads.js$xmlhttprequest,first-party
playview.io##.ads_player

! https://forums.lanik.us/viewtopic.php?f=62&t=39280&p=129024#p129024
$websocket,domain=readcomics.website
readcomics.website##script:inject(abort-current-inline-script.js, TextDecoder, atob)
readcomics.website##script:inject(nowebrtc.js)
||jojilabola.com^

10 comments on commit 4633bf8

@okiehsch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not work with Firefox on my end and the nowebrtc.js will not work, issue gorhill/uBlock#1930 (comment)

annt

@mapx-
Copy link
Contributor Author

@mapx- mapx- commented on 4633bf8 Dec 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do these ones work for you ?

readcomics.website##iframe
readcomics.website##.ads
readcomics.website##DIV[style="display: block; margin: 0px auto;"]

@mapx-
Copy link
Contributor Author

@mapx- mapx- commented on 4633bf8 Dec 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

even better
||readcomics.website^$csp=script-src 'self' * 'unsafe-inline' data:

@okiehsch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but I think disabling the whole reinsertion process would be preferable, so
readcomics.website##script:inject(abort-on-property-write.js, decodeURIComponent)
works for me and I do not notice any site breakage, if somebody reports breakage caused by this filter
your suggested filterset can be used.

@okiehsch
Copy link
Contributor

@okiehsch okiehsch commented on 4633bf8 Dec 6, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

||readcomics.website^$csp=script-src 'self' * 'unsafe-inline' data: will certainly cause site breakage, this site uses Rocket Loader to load scripts and the csp will disable it.

https://support.cloudflare.com/hc/en-us/articles/200168056-What-does-Rocket-Loader-do-

@mapx-
Copy link
Contributor Author

@mapx- mapx- commented on 4633bf8 Dec 7, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This 1 does not break the navigation (arrows .. as happened with script-src)

||readcomics.website^$csp=connect-src *.readcomics.website

or if I want to permit other connections for example:

||readcomics.website^$csp=connect-src *.readcomics.website *.komoona.com

works FF / chrome.

Do you see something else broken ?

@okiehsch
Copy link
Contributor

@okiehsch okiehsch commented on 4633bf8 Dec 7, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot to link to the updated fix, sorry 0610ddd

With ||readcomics.website^$csp=connect-src *.readcomics.website I only see some minor layout breakage, but if I add

readcomics.website#@#script:inject(abort-on-property-write.js, decodeURIComponent)
||readcomics.website^$csp=connect-src *.readcomics.website

I still get a WebRTC-connection
wer

which readcomics.website#@#script:inject(abort-on-property-write.js, decodeURIComponent) disables.

@mapx-
Copy link
Contributor Author

@mapx- mapx- commented on 4633bf8 Dec 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, in chrome still does not exist some no-webrtc directive in CSP, but in this case I see no ads using only connect-src (and sure - disabling "ublock filters").

Sure, it's better killing the generation of all crap, it was just my curiosity experimenting this CSP weapon.

@mapx-
Copy link
Contributor Author

@mapx- mapx- commented on 4633bf8 Dec 7, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested connect-src on clashdaily.com - in FF it's ok, in chrome the webrtc ads are still present.

@okiehsch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With only ||readcomics.website^$csp=connect-src *.readcomics.website I still see ads
ads
it just takes longer for them to appear on my end.
It works fine with Firefox.
Same behaviour at clashdaily.com.

Please sign in to comment.