Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scheduled release action for builtins #260

Merged
merged 3 commits into from
Feb 15, 2025

Conversation

masklinn
Copy link
Contributor

The workflow didn't work because it falls back to the ref "master" which the checkout does not understand. Furthermore because there is no explicit environment in the scheduled case the job description says it's deploying to "dummy" which is not true and also not really convenient.

It would be better if we could set inputs for other trigger events than workflow_dispatch (and I assume workflow_call or whatever it's called), but apparently not.

Apparently the way submodules repos are configured leads to the branches not being mirrored locally (?) As such, the release job's fallback of checking out `'master'` fails whether triggered[^1] or scheduled[^2].

[^1]: https://github.com/ua-parser/uap-python/actions/runs/13090871627
[^2]: https://github.com/ua-parser/uap-python/actions/runs/13092233962
Since the environment is required via `workflow_dispatch`, the only fallback is scheduled release in which case we're publishing to pypy.
@masklinn masklinn enabled auto-merge (rebase) February 15, 2025 13:07
@masklinn masklinn merged commit 60b35ec into ua-parser:master Feb 15, 2025
26 checks passed
@masklinn masklinn deleted the scheduled-job-fix branch February 15, 2025 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant