Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing jQuery with native JS #108

Merged
merged 3 commits into from
May 14, 2024
Merged

Conversation

aestoltm
Copy link
Contributor

@aestoltm aestoltm commented May 10, 2024

Description

Replaces any jQuery calls with native JavaScript. This PR is dependent on the base xdmod jQuery PR. Most of the changes are with the AppKernel Scheduler displayed in the internal dashboard.

Note: There is a bug with creating tasks in the internal dashboard App KernelsSchedule tab. This is the exception thrown when trying to create a task:
Call to undefined method Rest\Controllers\AkrrControllerProvider::_parseRestArguments()

Motivation and Context

jQuery is a large dependency that we use very sparingly.

Tests performed

Ran tests in docker container and viewed changes on xdmod-dev.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project as found in the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@aestoltm aestoltm added this to the 11.0.0 milestone May 10, 2024
@aestoltm aestoltm self-assigned this May 10, 2024
@aestoltm aestoltm merged commit 04a7393 into ubccr:xdmod11.0 May 14, 2024
3 checks passed
@aestoltm aestoltm mentioned this pull request May 30, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants