Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert compactCells to use int64_t for indexing #920

Merged

Conversation

isaacbrodsky
Copy link
Collaborator

Based on #919, this converts the internal indexing to be 64 bit. This could be tested but needs a special setup since the memory requirements exceed small devices.

@isaacbrodsky isaacbrodsky marked this pull request as draft September 30, 2024 22:25
@coveralls
Copy link

coveralls commented Sep 30, 2024

Coverage Status

coverage: 98.824%. remained the same
when pulling 8b15c3e on isaacbrodsky:compact_all_res1_tes-proposed-fix-int64_t
into d6f2701 on uber:master.

@isaacbrodsky isaacbrodsky mentioned this pull request Oct 1, 2024
@isaacbrodsky isaacbrodsky marked this pull request as ready for review October 1, 2024 23:44
@isaacbrodsky isaacbrodsky merged commit a67f563 into uber:master Oct 17, 2024
38 checks passed
@isaacbrodsky isaacbrodsky deleted the compact_all_res1_tes-proposed-fix-int64_t branch October 17, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants