Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Dynamic Variable Usage for Affection Level Adjustment #171

Closed
WilsonGoins opened this issue Feb 23, 2025 · 2 comments
Closed

Implement Dynamic Variable Usage for Affection Level Adjustment #171

WilsonGoins opened this issue Feb 23, 2025 · 2 comments
Assignees
Labels
easy A easy issue good first issue Good for newcomers PR Pending There is a PR for this that has changes requested or needs to be reviewed

Comments

@WilsonGoins
Copy link
Collaborator

Implement Dynamic Variable Usage for Affection Level Adjustment

Description

Whenever we change someone's affection levels we are doing it with an integer. It should be with a variable that references a single instance of an integer which should be stored in script.rpy. This is so that if we want to change how affection levels are balanced throughout the game we only have to change it in one place in the future. Likewise, if we want a choice to severely impact a relationship, we can just do "affectionChange * 2" instead of doing the math that might get lost or misinterpreted later on.

Objective

  • Create a single global variable in "script.rpy" that will be referenced throughout the game as the amount to add or subtract from someone's affection level as a result of some action.
  • Replace all usage of integers with this variable and scale accordingly. (ex: default is +- 2, I believe. So if it is at 2 you just replace with variable, if it's at 4 you replace with variable * 2).
  • Verify game runs correctly and that this is all being tracked properly from stage to stage of the game.

Resources

  • The scripts are available in the Google Drive. Access will be granted upon request.

Collaboration

  • Feel free to discuss ideas and share progress through our Discord and this chat.

Expected Deliverables

  • New variable referenced throughout script to replace current use of integers.

Additional Context

  • n/a

Severity: High
Priority: High

@WilsonGoins WilsonGoins added easy A easy issue good first issue Good for newcomers labels Feb 23, 2025
@TYPSwift
Copy link
Contributor

Can I work on this issue?

@WilsonGoins
Copy link
Collaborator Author

Can I work on this issue?

Yes, remember that these changes need to be made for every single script file we have which is 10+ files, I believe. Let me know if you have any questions.

@WilsonGoins WilsonGoins added the PR Pending There is a PR for this that has changes requested or needs to be reviewed label Feb 27, 2025
nickv779 added a commit that referenced this issue Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy A easy issue good first issue Good for newcomers PR Pending There is a PR for this that has changes requested or needs to be reviewed
Projects
None yet
Development

No branches or pull requests

2 participants