Fix Animation in Coding Scene - Pt. 2 #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickv779
requested changes
Feb 14, 2025
| c "\"Whatever.\"" | ||
| c "\"You guys didn't know the answer either.\"" | ||
| hide cpp_talk | ||
| show cpp_normal at left |
There was a problem hiding this comment.
need to show python talking here
| @@ -587,19 +610,25 @@ label w0_d2_AfterLunch: | |||
|
|
|||
| mc "\"Oh man, that’s my bad guys.\"" | |||
| mc "\"I see how that is the answer.\"" | |||
|
|
|||
| show python_pocket_happy | |||
There was a problem hiding this comment.
python is showing up in the middle talking, fix so it's on the right and the original image is removed too
| js "\"OMG Yes!!!\"" | ||
| hide js_talk |
There was a problem hiding this comment.
replace the js not talking image with the smirk
|
@nickv779 I committed the requested changes. |
nickv779
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses and resolves Issue #146 by improving character animations in the coding scene (w0_d2) at orientation. The following fixes and enhancements have been implemented:
Changes Made:
Characters now open and close their mouths appropriately during dialogue.
Speech animation timing aligns with the length of each line spoken.
Ensured Proper Character Display:
All characters relevant to the coding scene are now properly displayed.
Characters do not disappear unexpectedly between dialogue transitions.
Improved Emotional Expressions:
Characters now switch between appropriate expressions based on their emotions in the conversation.
Testing and Verification:
Playtested the scene multiple times to confirm smooth animation transitions.
Checked for any unintended character visibility issues.
Ensured that character emotions match their dialogue context.