-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Animation in Coding Scene - Pt. 2 #157
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
requested some changes
c "\"Whatever.\"" | ||
c "\"You guys didn't know the answer either.\"" | ||
hide cpp_talk | ||
show cpp_normal at left |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to show python talking here
@@ -587,19 +610,25 @@ label w0_d2_AfterLunch: | |||
|
|||
mc "\"Oh man, that’s my bad guys.\"" | |||
mc "\"I see how that is the answer.\"" | |||
|
|||
show python_pocket_happy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
python is showing up in the middle talking, fix so it's on the right and the original image is removed too
js "\"OMG Yes!!!\"" | ||
hide js_talk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
replace the js not talking image with the smirk
@nickv779 I committed the requested changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good now, awesome stuff
This PR addresses and resolves Issue #146 by improving character animations in the coding scene (w0_d2) at orientation. The following fixes and enhancements have been implemented:
Changes Made:
Characters now open and close their mouths appropriately during dialogue.
Speech animation timing aligns with the length of each line spoken.
Ensured Proper Character Display:
All characters relevant to the coding scene are now properly displayed.
Characters do not disappear unexpectedly between dialogue transitions.
Improved Emotional Expressions:
Characters now switch between appropriate expressions based on their emotions in the conversation.
Testing and Verification:
Playtested the scene multiple times to confirm smooth animation transitions.
Checked for any unintended character visibility issues.
Ensured that character emotions match their dialogue context.