Fix potential memory leak for cache ram #13525
Open
+11
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered a memory leak when customizing Yolov5 cache ram. The plan was to allowing caching partial dataset on RAM if there's not enough memory for the whole dataset.
The change ensures the ThreadPool used for caching data is closed when it's done their duty.
This improves code extensibility, ensures threads are closed when they finished their tasks.
I have read the CLA Document and I sign the CLA
🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
🌟 Summary
Enhanced the image caching process for improved efficiency and resource management during dataset loading. 🛠️💾
📊 Key Changes
ThreadPool
instantiation and usage with a context manager (with ThreadPool
), ensuring cleaner and safer thread lifecycle management. 🔄🎯 Purpose & Impact
with
context ensures threads are properly closed, reducing the chance of resource leaks or crashes. 🙌