oxc-resolver has been a breaking change

[mrginglymus]

I've just tried to update to latest version of the plugin. oxc-resolver appears incompatible with yarn PnP (at least out of the box).

Switching to the node-modules linker at least allows it to resolve packages, but it then seems to have some trouble importing .css files which previously worked without additional config.

{
    settings: {
      "import-x/resolver-next": [
        importPlugin.createNodeResolver({
          extensions: [".ts", ".tsx", ".js"],
          conditionNames: ["my-condition", "import"],
          extensionAlias: {
            ".js": [".ts", ".js"],
          },
        }),
      ],
      "import-x/internal-regex": "^@my-namespace/",
      "import-x/external-module-folders": [".yarn"],
      "import-x/parsers": {
        "@typescript-eslint/parser": [".ts", ".tsx"],
      },
    },

[JounQin]

Can you provide a runnable reproduction?

[mrginglymus]

oxc-project/oxc-resolver#53 looks like pnp support is not yet enabled in oxc-resolver?

edit; or possibly not. will try and make a minimal repro

[JounQin]

web-infra-dev/rspack-resolver#53 could be replacement, I'll publish into npm manually for now.

[mrginglymus]

https://github.com/mrginglymus/epix-oxc trivial repro - works fine with node-modules, explodes with pnp

I suspect the css import issue might be fixable with config.

[JounQin]

@mrginglymus Could you help to test #243?

# yarn 1
yarn add https://pkg.csb.dev/un-ts/eslint-plugin-import-x/commit/d794a858/eslint-plugin-import-x
# yarn 2, 3
yarn add eslint-plugin-import-x@https://pkg.csb.dev/un-ts/eslint-plugin-import-x/commit/d794a858/eslint-plugin-import-x/_pkg.tgz
# npm
npm i https://pkg.csb.dev/un-ts/eslint-plugin-import-x/commit/d794a858/eslint-plugin-import-x

[mrginglymus]

This works a lot better! It's now able to resolve all modules. I am, however, still hitting two issues:

1. I have some custom export conditions which resolve to a path with a trailing querystring. This is probably a vile abuse, but it used to work and now doesn't.
2. rspack-resolver does not resolve pnpapi

[mrginglymus]

For 1. I can fix with config using an extension alias:

{
  extensionAlias: {
    ".css?parp": [".css"]
  }
}

though that then does result in import-x claiming 'duplicate' imports where there are none.

[mrginglymus]

I've updated the repro using #243 and added a pnpapi import.

[JounQin]

I have some custom export conditions which resolve to a path with a trailing querystring. This is probably a vile abuse, but it used to work and now doesn't.

@mrginglymus Can you add this into the reproduction?

For pnpapi:

# yarn 1
yarn add https://pkg.csb.dev/un-ts/eslint-plugin-import-x/commit/c115e722/eslint-plugin-import-x
# yarn 2, 3
yarn add eslint-plugin-import-x@https://pkg.csb.dev/un-ts/eslint-plugin-import-x/commit/c115e722/eslint-plugin-import-x/_pkg.tgz
# npm
npm i https://pkg.csb.dev/un-ts/eslint-plugin-import-x/commit/c115e722/eslint-plugin-import-x

[mrginglymus]

@JounQin updated, thanks! pnpapi working, added repro for querystring import

[JounQin]

I tried original oxc-resolver, it's not supported w/o pnp, but I think it should be supported. cc @Boshen

{
  "exports": {
    ".": "./index.js",
    "./add": "./add.js?custom"
  }
}

I'll try to fix it at our own fork temporarily.

[JounQin]

# yarn 1
yarn add https://pkg.csb.dev/un-ts/eslint-plugin-import-x/commit/27012bc4/eslint-plugin-import-x
# yarn 2, 3
yarn add eslint-plugin-import-x@https://pkg.csb.dev/un-ts/eslint-plugin-import-x/commit/27012bc4/eslint-plugin-import-x/_pkg.tgz
# npm
npm i https://pkg.csb.dev/un-ts/eslint-plugin-import-x/commit/27012bc4/eslint-plugin-import-x

@mrginglymus Working as expected now.

[mrginglymus]

Amazing! Yes, works for me. The only remaining difference is that now pnpapi is coming up as a different import group - though I think this new behaviour is more correct as it's getting grouped as an external dep.

Thanks so much for the quick turnaround on this.

[JounQin]

The only remaining difference is that now pnpapi is coming up as a different import group - though I think this new behaviour is more correct as it's getting grouped as an external dep.

@mrginglymus In my PR https://github.com/un-ts/eslint-plugin-import-x/pull/243/files#diff-ad71c478de212fc2376c95a6ef7a5b2b24f2e2791c15b1d1c362d6342e4d0ae4R54, I marked pnpapi as core module for pnp, but I just checked enhanced-resolve, it resolves pnpapi as <root>/.pnp.cjs, maybe I should align its behavior.

[JounQin]

Should we mark pnpapi as core in PnP? This is a question.

@mrginglymus @SukkaW What do you think?

[mrginglymus]

@JounQin I've updated to the latest version and I'm getting intermittent linting failures of this plugin, which is a new one to me! It seems to be a import-x/no-unresolved for every third party import. Will keep investigating and see if I can find a cause...