Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit era names, fix bugs #6248

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

robertbastian
Copy link
Member

@robertbastian robertbastian commented Mar 6, 2025

The bug fix is that Japanese's gregorian eras were mixed up in datetime

@robertbastian robertbastian marked this pull request as ready for review March 6, 2025 23:05
@robertbastian robertbastian requested review from sffc, Manishearth and a team as code owners March 6, 2025 23:05
Manishearth
Manishearth previously approved these changes Mar 6, 2025
@@ -64,3 +64,29 @@ impl From<RangeError> for DateError {
}
}
}

pub(crate) fn year_check(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants