Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate calendar code against CLDR Era data #6252

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Validate calendar code against CLDR Era data #6252

wants to merge 3 commits into from

Conversation

robertbastian
Copy link
Member

@robertbastian robertbastian commented Mar 7, 2025 •
edited
Loading

This uncovered a handful of bugs

  • The Ethiopic epoch in calendrical-calculations was off by two days
  • Multiple Japanese eras have invalid start dates (Feb 29 and Feb 30)
  • One calendar still returned the wrong era code
  • Many eras start dates in CLDR do not agree with what our code calculates. Needs investigation

@robertbastian robertbastian force-pushed the eravalidation branch 2 times, most recently from b1a607f to 466f0f6 Compare March 7, 2025 05:01
@robertbastian robertbastian marked this pull request as ready for review March 7, 2025 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sffc sffc Awaiting requested review from sffc sffc is a code owner

@Manishearth Manishearth Awaiting requested review from Manishearth Manishearth is a code owner

@zbraniecki zbraniecki Awaiting requested review from zbraniecki zbraniecki is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@robertbastian