Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WASM changing scroll position on focus changing + fix keyboard focus not bringing the new focus target into view #15354

Merged
merged 10 commits into from
Feb 16, 2024

Conversation

ramezgerges
Copy link
Contributor

GitHub Issue (If applicable): https://github.com/unoplatform/uno.chefs/issues/998

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15354/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15354/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-15354/index.html

@ramezgerges
Copy link
Contributor Author

@MartinZikmund SelectingTimeSetsSelectedTime is failing, so I went to test it out locally, and it doesn't seem to be working locally even on master. Any idea why?

Failed: SelectingTimeSetsSelectedTime() [System.ArgumentException] 
 System.ArgumentException: value
   at Windows.Globalization.Calendar.set_Period(Int32 value) in D:\uno\src\Uno.UWP\Globalization\Calendar.cs:line 296
   at Uno.UI.RuntimeTests.Tests.Windows_UI_Xaml_Controls.TimePickerIntegrationTests.CreateTime(Int32 hours, Int32 minutes, Int32 period) in D:\uno\src\Uno.UI.RuntimeTests\MUX\Microsoft_UI_Xaml_Controls\TimePicker\TimePickerIntegrationTests.cs:line 28
   at Uno.UI.RuntimeTests.Tests.Windows_UI_Xaml_Controls.TimePickerIntegrationTests.SelectingTimeSetsSelectedTime() in D:\uno\src\Uno.UI.RuntimeTests\MUX\Microsoft_UI_Xaml_Controls\TimePicker\TimePickerIntegrationTests.cs:line 279
   at Uno.UI.Samples.Tests.UnitTestsControl.<>c__DisplayClass63_2.<<ExecuteTestsForInstance>g__InvokeTestMethod|3>d.MoveNext() in D:\uno\src\SamplesApp\SamplesApp.UnitTests.Shared\Controls\UnitTest\UnitTestsControl.cs:line 894

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15354/index.html

@MartinZikmund
Copy link
Member

@MartinZikmund SelectingTimeSetsSelectedTime is failing, so I went to test it out locally, and it doesn't seem to be working locally even on master. Any idea why?

Failed: SelectingTimeSetsSelectedTime() [System.ArgumentException] 
 System.ArgumentException: value
   at Windows.Globalization.Calendar.set_Period(Int32 value) in D:\uno\src\Uno.UWP\Globalization\Calendar.cs:line 296
   at Uno.UI.RuntimeTests.Tests.Windows_UI_Xaml_Controls.TimePickerIntegrationTests.CreateTime(Int32 hours, Int32 minutes, Int32 period) in D:\uno\src\Uno.UI.RuntimeTests\MUX\Microsoft_UI_Xaml_Controls\TimePicker\TimePickerIntegrationTests.cs:line 28
   at Uno.UI.RuntimeTests.Tests.Windows_UI_Xaml_Controls.TimePickerIntegrationTests.SelectingTimeSetsSelectedTime() in D:\uno\src\Uno.UI.RuntimeTests\MUX\Microsoft_UI_Xaml_Controls\TimePicker\TimePickerIntegrationTests.cs:line 279
   at Uno.UI.Samples.Tests.UnitTestsControl.<>c__DisplayClass63_2.<<ExecuteTestsForInstance>g__InvokeTestMethod|3>d.MoveNext() in D:\uno\src\SamplesApp\SamplesApp.UnitTests.Shared\Controls\UnitTest\UnitTestsControl.cs:line 894

Very interesting! Can you please debug what is the value the Period setter is trying to set? Thanks!

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-15354/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15354/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-15354/index.html

@ramezgerges ramezgerges merged commit 38924fc into unoplatform:master Feb 16, 2024
92 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants