Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👌 Improve process_constraints #1015

Merged
merged 4 commits into from
Sep 7, 2023
Merged

Conversation

chrisjsewell
Copy link
Member

  • Add deprecation warning for needs_constraints_failed_color config option, which is no longer used
  • Improve exception messages for missing keys in config options
  • Add source location to failing constraints warnings
  • Improve docstrings and type annotations for data fields/config options

- Add deprecation warning for `needs_constraints_failed_color`, which is no longer used
- Improve exceptions for missing keys in config
- Add source location to failing constraints warnings
-  Improve docstrings and type annotations for data fields/config options
@chrisjsewell chrisjsewell requested a review from danwos September 6, 2023 13:21
Copy link
Member

@danwos danwos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@chrisjsewell chrisjsewell merged commit 795ca19 into master Sep 7, 2023
@chrisjsewell chrisjsewell deleted the improve-process_constraint branch September 7, 2023 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants