Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👌 Removing deepcopy #1033

Merged
merged 4 commits into from
Sep 27, 2023
Merged

👌 Removing deepcopy #1033

merged 4 commits into from
Sep 27, 2023

Conversation

danwos
Copy link
Member

@danwos danwos commented Sep 20, 2023

Tasks to do:

Looks like this little change brings up to 80% better performance in a build.
Huge project got down to 5min from 28min.
Also memory consumption is cut down to 50-60%.

@danwos danwos changed the title removing deepcopy. 👌 Removing deepcopy Sep 20, 2023
@danwos danwos marked this pull request as ready for review September 27, 2023 10:50
@danwos danwos requested a review from chrisjsewell September 27, 2023 10:51
@danwos
Copy link
Member Author

danwos commented Sep 27, 2023

Right, always forget about the old code comments

Copy link
Member

@chrisjsewell chrisjsewell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers

@danwos danwos merged commit 469c77c into master Sep 27, 2023
@danwos danwos deleted the no_deepcopy branch September 27, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants