Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update permalink.html with a frienly text #1081

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Conversation

csIcaK
Copy link
Contributor

@csIcaK csIcaK commented Dec 5, 2023

Changed

  • added text to display while loading the content.

Reason

Currently on bigger projects it takes considerable amount of time to load the location of the selected ID. During that time currently there is a blank page shown to the user.

This change will display a static text: Searching, Please Wait...

added text to display while loading the content.
Copy link

codecov bot commented Dec 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.27%. Comparing base (150bcd6) to head (6fc6623).
Report is 67 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1081   +/-   ##
=======================================
  Coverage   79.27%   79.27%           
=======================================
  Files          56       56           
  Lines        6460     6460           
=======================================
  Hits         5121     5121           
  Misses       1339     1339           
Flag Coverage Δ
pytests 79.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@danwos danwos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change, a big improvement in the usability. Thanks for the PR 👍

@danwos danwos merged commit c27bc64 into useblocks:master Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants