🔧 Fix typing of need docname/lineno #1134
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Account for these being
None
for external needs, that have no source mapping within the projectPractically, if
is_external is False
thendocname/lineno
arestr
, but ifis_external is True
thendocname/lineno
areNone
.This internal relationship is difficult to encode in the type system though.
So here we always account for
docname is None
, even if we have already checked foris_external is False