🐛 FIX: Image layout function #1135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danwos
force-pushed
the
fix_image_layout
branch
from
e2a1120 to
8869ed5
Compare
danwos
changed the title
Removes the relative path calculation from the "image" function in layout.py,as it was broken. Now all set url-paths must be relative to the documentation root.
danwos
force-pushed
the
fix_image_layout
branch
from
27539a1 to
0a29976
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1135 +/- ##
==========================================
- Coverage 85.94% 85.92% -0.03%
==========================================
Files 56 56
Lines 6539 6536 -3
==========================================
- Hits 5620 5616 -4
- Misses 919 920 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -283,6 +284,16 @@ def test_app(make_app, sphinx_test_tempdir, request): | |||
| docutilsconf=builder_params.get("docutilsconf"), | |||
| parallel=builder_params.get("parallel", 0), | |||
| ) | |||
| # Add the Sphinx warning as list to the app | |||
| # Somehow "app._warning" seems to be just a boolean, if the builder is "latex" or "singlehtml". | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the relative path calculation from the "image" function in layout.py,as it was broken.
Now all set url-paths must be relative to the documentation root.