♻️ Remove back link manipulation from needextend
#1386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Back links are computed at the end of the need post-processing, after `needextend` have been applied. Back links should always be in-sync with forward links, therefore it doesn't make sense to modify back links in this way. Thankfully, the current availability of back link options in `needextend` directives is not documented, and so are unlikely to have been actually used.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1386 +/- ##
==========================================
+ Coverage 86.87% 87.98% +1.10%
==========================================
Files 56 60 +4
Lines 6532 7131 +599
==========================================
+ Hits 5675 6274 +599
Misses 857 857
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ubmarco
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back links are computed at the end of the need post-processing, after
needextendhave been applied.Back links should always be in-sync with forward links, therefore it doesn't make sense to modify back links in this way.
Thankfully, the current availability of back link options in
needextenddirectives is not documented, and so are unlikely to have been actually used.