🔧 Centralise extendable core need fields #1388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1388 +/- ##
==========================================
+ Coverage 86.87% 88.18% +1.30%
==========================================
Files 56 60 +4
Lines 6532 7128 +596
==========================================
+ Hits 5675 6286 +611
+ Misses 857 842 -15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ubmarco
reviewed
Jan 27, 2025
sphinx_needs/data.py
Outdated
| @@ -132,12 +138,14 @@ class CoreFieldParameters(TypedDict): | |||
| "schema": {"type": ["string", "null"], "default": None}, | |||
| "show_in_layout": True, | |||
| "exclude_external": True, | |||
| "allow_extend": True, | |||
There was a problem hiding this comment.
Isn't this evaluated during add_need so needextend will not see the need if it is deleted?
There was a problem hiding this comment.
There is already a PR to completely remove this field, so it doesn't really matter: #1347
chrisjsewell
force-pushed
the
restrict-needextend-core
branch
from
0e7942e to
21d810e
Compare
chrisjsewell
commented
Jan 27, 2025
ubmarco
approved these changes
Jan 27, 2025
chrisjsewell
added a commit
that referenced
this pull request
Mar 13, 2025
Similar to #1388 for `needs_variant_options`
chrisjsewell
added a commit
that referenced
this pull request
Mar 14, 2025
Similar to #1388 for `needs_variant_options` --------- Co-authored-by: Marco Heinemann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.