♻️ Remove full_title need field and only trim generated titles
#1407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the documentation for `needs_max_title_length`, it states: > This option is used in conjunction with auto-generated titles as controlled by `needs_title_from_content` However, this was not the case; it was being trimmed for all titles, irrespective of if they were auto-generated. Trimming is now only applied to auto-generated titles (an the untrimmed title is still used for ID generation), The existence of both `title` and `full_title` is confusing and unnecessary and so `full_title` is removed.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1407 +/- ##
==========================================
+ Coverage 86.87% 88.23% +1.35%
==========================================
Files 56 60 +4
Lines 6532 7148 +616
==========================================
+ Hits 5675 6307 +632
+ Misses 857 841 -16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
danwos
approved these changes
Feb 19, 2025
|
Makes sense. Thanks for the implementation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the documentation for
needs_max_title_length, it states:However, this was not the case; it was being trimmed for all titles, irrespective of if they were auto-generated.
Trimming is now only applied to auto-generated titles (and the untrimmed title is still used for ID generation),
The existence of both
titleandfull_titleis confusing and unnecessary (in most cases these are equal), and sofull_titleis removed.