Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allowing newer versions of jsonschema #848

Merged
merged 1 commit into from
Jan 2, 2023
Merged

Allowing newer versions of jsonschema #848

merged 1 commit into from
Jan 2, 2023

Conversation

danwos
Copy link
Member

@danwos danwos commented Jan 2, 2023 •
edited
Loading

Fix for #847

@danwos danwos merged commit c9972d0 into master Jan 2, 2023
@danwos danwos deleted the json_dep branch January 2, 2023 08:40
@danwos danwos mentioned this pull request Jan 2, 2023
Closed
@bluenote10
Copy link
Contributor

bluenote10 commented Jan 23, 2023 •
edited
Loading

Thanks for the fix!

Would it be possible to make a new release of sphinx-needs with this adjustment?

The issue is that the current pinning of jsonschema=3.2.0 is hard-coding sphinx-needs to a very old jsonschema version from December 2019, which makes it impossible to properly use sphinx-needs in combination with other packages that have more modern minimum requirements on jsonschema.

@bluenote10 bluenote10 mentioned this pull request Jan 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danwos @bluenote10