Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed pygls v1.0 module import error #868

Merged
merged 7 commits into from
Feb 8, 2023
Merged

Fixed pygls v1.0 module import error #868

merged 7 commits into from
Feb 8, 2023

Conversation

haiyangToAI
Copy link
Contributor

No description provided.

danwos
danwos requested changes Feb 8, 2023
View reviewed changes
@danwos danwos mentioned this pull request Feb 8, 2023
Closed
danwos
danwos requested changes Feb 8, 2023
View reviewed changes
Copy link
Member

@danwos danwos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to add packaging package to the pyproject.toml file as a dependency.

In most cases, it should be already there, as it is needed by setuptools.
But just to be sure :)

@haiyangToAI haiyangToAI force-pushed the bugfix_pygls_version_compatiablity branch from 3b2128d to 558b212 Compare February 8, 2023 09:25
@haiyangToAI haiyangToAI marked this pull request as ready for review February 8, 2023 10:05
@haiyangToAI haiyangToAI requested a review from danwos February 8, 2023 10:05
danwos
danwos approved these changes Feb 8, 2023
View reviewed changes
Copy link
Member

@danwos danwos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the quick fix.

@danwos danwos merged commit f50f1fe into master Feb 8, 2023
@danwos danwos deleted the bugfix_pygls_version_compatiablity branch February 8, 2023 10:34
@danwos danwos mentioned this pull request Feb 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danwos danwos danwos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haiyangToAI @danwos