Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

small timer fix in counters. #128

Merged
merged 1 commit into from
Jul 17, 2024
Merged

small timer fix in counters. #128

merged 1 commit into from
Jul 17, 2024

Conversation

tewaro
Copy link
Contributor

@tewaro tewaro commented Jul 16, 2024

No description provided.

@tewaro tewaro force-pushed the AdityaAtulTewari/small-timer-fix branch from 70c336a to 2288fc3 Compare July 17, 2024 22:59
@tewaro tewaro requested a review from elgarten July 17, 2024 23:00
@tewaro tewaro merged commit 8d824be into main Jul 17, 2024
20 checks passed
@tewaro tewaro deleted the AdityaAtulTewari/small-timer-fix branch July 17, 2024 23:34
elgarten
elgarten reviewed Jul 18, 2024
View reviewed changes
Copy link
Contributor

@elgarten elgarten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my end, still has an issue with multiple processes logging on top of each other, I'll modify my commit for that to merge with this code and submit a PR for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elgarten elgarten elgarten left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tewaro @elgarten