-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run all workspace tests in CI (x86-64 Linux) #7392
Comments
drinkcat
added a commit
to drinkcat/coreutils
that referenced
this issue
Mar 4, 2025
Add a new Linux build that runs without `cross`, and adds `--workspace` to the cargo test command. From cargo test documentation, this option "tests all members in the workspace.". For example, this includes running tests within the `uucore` package (see uutils#7383). Fixes uutils#7392.
This was referenced Mar 4, 2025
drinkcat
added a commit
to drinkcat/coreutils
that referenced
this issue
Mar 4, 2025
Add a new Linux build that runs without `cross`, and adds `--workspace` to the cargo test command. From cargo test documentation, this option "tests all members in the workspace.". For example, this includes running tests within the `uucore` package (see uutils#7383). Fixes uutils#7392.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In #7383, we noticed that CI is not running all tests. For example, tests for package
uucore
are not being run.I believe the right solution is to run the tests with the
--workspace
flag:I did some experiments in #7386, where I first tried to add
--workspace
unconditionally to thecargo test
command.windows/macos/linux-musl builds are broken: we could try to fix this later (I'll probably file other issues).
Even
x86_64-unknown-linux-gnu
builds are built usingcross
. First, the selinux dependency was not met. This could be fixed by adding aCross.toml
file that pulls inlibselinux1-dev
(see this example). But even then, the problem is thatghcr.io/cross-rs/x86_64-unknown-linux-gnu:0.2.5
is ancient (Ubuntu 16.04),so the provided libclang is too old, and the build fails with:
My current idea is to add a new job to the matrix that uses
cargo
directly (nocross
). But that currently fails with:The text was updated successfully, but these errors were encountered: