Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce basic pre/post processor logic #96

Merged
merged 7 commits into from
Feb 16, 2022
Merged

Introduce basic pre/post processor logic #96

merged 7 commits into from
Feb 16, 2022

Conversation

Antony1060
Copy link
Contributor

Closes #93

@Antony1060 Antony1060 marked this pull request as draft February 13, 2022 23:00
@Antony1060
Copy link
Contributor Author

Need to fix test coverage, it has some weird artifacts

@Antony1060 Antony1060 marked this pull request as ready for review February 14, 2022 16:14
@Antony1060 Antony1060 requested a review from a team February 14, 2022 16:16
svemat01
svemat01 approved these changes Feb 15, 2022
View reviewed changes
Copy link
Member

@svemat01 svemat01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but wait for another review

lucemans
lucemans reviewed Feb 16, 2022
View reviewed changes
src/index.ts
@@ -72,6 +72,10 @@ export type LogConfig = SharedConfig & {
* @example ['error', 'important', 'success'] (only logs error, important, and success)
*/
filter: RuntimeOrValue<string[] | undefined>;

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JSDocs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sowwy

lucemans
lucemans requested changes Feb 16, 2022
View reviewed changes
src/index.ts
@@ -72,6 +72,10 @@ export type LogConfig = SharedConfig & {
* @example ['error', 'important', 'success'] (only logs error, important, and success)
*/
filter: RuntimeOrValue<string[] | undefined>;

preProcessors?: ((input: LogMethodInput[], method: { name: M } & MethodConfig, logger: LogConfig<M>) => LogMethodInput[])[];

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JSDocs?

@Antony1060 Antony1060 requested a review from lucemans February 16, 2022 18:58
lucemans
lucemans approved these changes Feb 16, 2022
View reviewed changes
Copy link
Member

@lucemans lucemans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucemans lucemans merged commit fd9f1ef into master Feb 16, 2022
@lucemans lucemans deleted the preprocess branch February 16, 2022 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucemans lucemans lucemans approved these changes

@svemat01 svemat01 svemat01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Post-Processor
3 participants
@Antony1060 @lucemans @svemat01