Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explore removal of Apache's httpclient dependency from flow-server #14538

Closed
knoobie opened this issue Sep 15, 2022 · 1 comment · Fixed by #16897
Closed

Explore removal of Apache's httpclient dependency from flow-server #14538

knoobie opened this issue Sep 15, 2022 · 1 comment · Fixed by #16897
Labels
enhancement

Comments

@knoobie
Copy link
Contributor

knoobie commented Sep 15, 2022

Describe your motivation

Currently vaadin-flow (flow-server) has a dependency to the httpclient (4.5.13) from Apache. The only class that needs it in flow-server DefaultFileDownloader which is only used on build / development time.

Describe the solution you'd like

Remove the dependency to Apache's httpclient by e.g. using Java 9's HttpClient or by moving of the whole class and its callers to the dedicated maven / gradle base plugin to reduce the dependency on runtime / production mode.
@knoobie knoobie mentioned this issue Sep 15, 2022
Merged
mstahv added a commit that referenced this issue May 26, 2023
@mstahv
Use SDK http client instead of a separate http-client dependecy
0ecc50a 
Closes #14538
@mstahv mstahv mentioned this issue May 26, 2023
Merged
9 tasks
@mstahv
Copy link
Member

mstahv commented May 26, 2023

@Artur-, @caalador check the PR I drafted as Friday fun. Not sure if all the hacks ("all bytes downloaded etc") are still needed with the newer JDK httpclient. Also I have no idea why there is this username/password thingie in this class. Obsolete legacy from the frontend-maven-plugin?

mcollovati pushed a commit that referenced this issue Jun 8, 2023
@mstahv
chore: use SDK http client instead of a separate http-client dependen…
5a8225e 
…cy (#16897)

Closes #14538
vaadin-bot pushed a commit that referenced this issue Sep 19, 2023
@mstahv @vaadin-bot
chore: use SDK http client instead of a separate http-client dependen…
3b9be58 
…cy (#16897)

Closes #14538
vaadin-bot added a commit that referenced this issue Sep 19, 2023
@vaadin-bot @mstahv
chore: use SDK http client instead of a separate http-client dependen…
377cf93 
…cy (#16897) (#17656)

Closes #14538

Co-authored-by: Matti Tahvonen <[email protected]>
@knoobie knoobie mentioned this issue Sep 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: use SDK http client instead of a separate http-client dependency vaadin/flow
2 participants
@mstahv @knoobie