Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add missing brackets and update incorrect values in tests #106

Merged
merged 1 commit into from
Dec 10, 2019
Merged

add missing brackets and update incorrect values in tests #106

merged 1 commit into from
Dec 10, 2019

Conversation

jkvyff
Copy link
Collaborator

@jkvyff jkvyff commented Dec 10, 2019

Ref: #105

@jkvyff jkvyff requested a review from evanplaice December 10, 2019 04:41
@evanplaice
Copy link
Member

evanplaice commented Dec 10, 2019 •
edited
Loading

If you want to add the build (ie esm/cjs bundles, docs, typings) as well, you can run npm run build. Just be sure npm run preversion passes before you build. Otherwise, LGTM.

@jkvyff jkvyff merged commit 0823317 into master Dec 10, 2019
@evanplaice evanplaice deleted the fix-obj-invert branch December 12, 2019 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evanplaice evanplaice evanplaice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkvyff @evanplaice