Skip to content

Commit

Permalink
Go back to using exact React versions in Pages Router
Browse files Browse the repository at this point in the history
latest RCs have considerably diverged from rc.0
  • Loading branch information
eps1lon committed Jul 10, 2024
1 parent 3d7a7de commit 1b24101
Show file tree
Hide file tree
Showing 6 changed files with 10 additions and 10 deletions.
4 changes: 2 additions & 2 deletions packages/create-next-app/templates/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -184,8 +184,8 @@ export const installTemplate = async ({
* Default dependencies.
*/
dependencies: {
react: "19.0.0-rc.0",
"react-dom": "19.0.0-rc.0",
react: "19.0.0-rc-a26e3f403e-20240611",
"react-dom": "19.0.0-rc-a26e3f403e-20240611",
next: version,
},
devDependencies: {},
Expand Down
4 changes: 2 additions & 2 deletions packages/next/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,8 @@
"@opentelemetry/api": "^1.1.0",
"@playwright/test": "^1.41.2",
"babel-plugin-react-compiler": "*",
"react": "19.0.0-rc.0",
"react-dom": "19.0.0-rc.0",
"react": "19.0.0-rc-a26e3f403e-20240611",
"react-dom": "19.0.0-rc-a26e3f403e-20240611",
"sass": "^1.3.0"
},
"peerDependenciesMeta": {
Expand Down
2 changes: 1 addition & 1 deletion run-tests.js
Original file line number Diff line number Diff line change
Expand Up @@ -415,7 +415,7 @@ ${ENDGROUP}`)
// a starter Next.js install to re-use to speed up tests
// to avoid having to run yarn each time
console.log(`${GROUP}Creating Next.js install for isolated tests`)
const reactVersion = process.env.NEXT_TEST_REACT_VERSION || '19.0.0-rc.0'
const reactVersion = process.env.NEXT_TEST_REACT_VERSION || '19.0.0-rc-a26e3f403e-20240611'
const { installDir, pkgPaths, tmpRepoDir } = await createNextInstall({
parentSpan: mockTrace(),
dependencies: {
Expand Down
4 changes: 2 additions & 2 deletions test/e2e/next-test/first-time-setup-js/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
},
"dependencies": {
"next": "canary",
"react": "19.0.0-rc.0",
"react-dom": "19.0.0-rc.0"
"react": "19.0.0-rc-a26e3f403e-20240611",
"react-dom": "19.0.0-rc-a26e3f403e-20240611"
}
}
4 changes: 2 additions & 2 deletions test/e2e/next-test/first-time-setup-ts/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
},
"dependencies": {
"next": "canary",
"react": "19.0.0-rc.0",
"react-dom": "19.0.0-rc.0"
"react": "19.0.0-rc-a26e3f403e-20240611",
"react-dom": "19.0.0-rc-a26e3f403e-20240611"
},
"devDependencies": {
"@types/react": "^18",
Expand Down
2 changes: 1 addition & 1 deletion test/lib/next-modes/base.ts
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ export class NextInstance {
)

const reactVersion =
process.env.NEXT_TEST_REACT_VERSION || '19.0.0-rc.0'
process.env.NEXT_TEST_REACT_VERSION || '19.0.0-rc-a26e3f403e-20240611'
const finalDependencies = {
react: reactVersion,
'react-dom': reactVersion,
Expand Down

0 comments on commit 1b24101

Please sign in to comment.