Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add readable response for root router #39

Merged
merged 2 commits into from
Oct 8, 2021
Merged

add readable response for root router #39

merged 2 commits into from
Oct 8, 2021

Conversation

Reid00
Copy link
Contributor

@Reid00 Reid00 commented Sep 2, 2021

fix this PR: #38

@CLAassistant
Copy link

CLAassistant commented Sep 2, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@Reid00 Reid00 changed the title add readable respose for root router add readable response for root router Sep 2, 2021
@wey-gu
Copy link

wey-gu commented Sep 3, 2021 •
edited
Loading

On wording itself:

	res.Data = "Run Successfully!"
	res.Message = "Welcome Nebula-Http-GateWay!"
	this.Data["json"] = &res

How about s/Nebula-Http-GateWay/to nebula http gateway/ , please?

cc @hetao92 @yixinglu @Aiee @nianiaJR

wey-gu
wey-gu approved these changes Sep 4, 2021
View reviewed changes
Copy link

@wey-gu wey-gu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hetao92 hetao92 merged commit 9b0f206 into vesoft-inc:master Oct 8, 2021
@jamieliu1023 jamieliu1023 mentioned this pull request Oct 9, 2021
Closed
@jamieliu1023
Copy link

@Reid00 Thanks for your contribution to the Nebula Graph community! This is Jamie with Nebula and I'd like to email you the Nebula Contributor certificate and ship you a mug to mark this special moment. Could you please kindly reach me via jamie.liu(at)vesoft.com? Again, thanks for being a part of the Nebula community!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wey-gu wey-gu wey-gu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Reid00 @CLAassistant @wey-gu @jamieliu1023 @hetao92